Add s3 config option insecure_skip_verify #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
force-pushed
the
s3TLSSkipVerify
branch
3 times, most recently
from
1c9ef03
to
22db690
Compare
zalegrala
requested review from
knylander-grafana,
KMiller-Grafana,
joe-elliott,
annanay25,
mdisibio,
dgzlopes,
mapno and
kvrhdn
as code owners
joe-elliott
approved these changes
Jun 3, 2022
Comment on lines
537
to
539
| # optional. | ||
| # enable to skip verification of an HTTPs endpoint | ||
| [insecure_skip_verify: <bool>] |
There was a problem hiding this comment.
I know that this definition looks similar to those near it within the file. It could be improved by stating that a value of true causes the verification to be skipped, and that the default is false. (Did I get the implications right?)
When I read this, I have to make a mental jump to associating "enable" with the boolean value "true." Easy for me, but perhaps more difficult for others.
There was a problem hiding this comment.
Learned something by reading your comment. :) I would not have caught the same thing.
zalegrala
force-pushed
the
s3TLSSkipVerify
branch
from
da6da9f
to
050b4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we include an S3 config option to disable TLS verification on HTTPs endpoints.
Which issue(s) this PR fixes:
Fixes #1466
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]