You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
(1) If we try to autocomplete a query like { .foo=~"(a|b)"} it seems like it should work but it doesn't (any tag name, doesn't matter). From debugging it is failing the check for single spanset operation, so probably the pipe | is incorrectly caught as a OR operation. Likely just need a tweak to the singleFilterRegexp regex: https://github.com/grafana/tempo/blob/main/pkg/traceql/extractmatcher.go#L36
(2) Simplifying the condition to =~"a" it still doesn't work. Here it is failing the matchersRegexp. I believe it's this section: [=|<=|>=|=~|!=|>|<|!~] which needs to be wrapped in parens instead of brackets to catch the multi-char operators: (=|<=|>=|=~|!=|>|<|!~)
Here's are some test cases for TextExtractMatchers:
…tchers (#3641)
* fix(traceql): fix extract matcher regexes to work with regexp-type matchers
Partially fixes#3635.
I'm going to add a further test case which this doesn't fix.
* Add more test cases for extract matcher
* Add CHANGELOG entry
Describe the bug
(1) If we try to autocomplete a query like
{ .foo=~"(a|b)"}
it seems like it should work but it doesn't (any tag name, doesn't matter). From debugging it is failing the check for single spanset operation, so probably the pipe|
is incorrectly caught as a OR operation. Likely just need a tweak to thesingleFilterRegexp
regex: https://github.com/grafana/tempo/blob/main/pkg/traceql/extractmatcher.go#L36(2) Simplifying the condition to
=~"a"
it still doesn't work. Here it is failing thematchersRegexp
. I believe it's this section:[=|<=|>=|=~|!=|>|<|!~]
which needs to be wrapped in parens instead of brackets to catch the multi-char operators:(=|<=|>=|=~|!=|>|<|!~)
Here's are some test cases for TextExtractMatchers:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Environment:
Additional Context
The text was updated successfully, but these errors were encountered: