-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(traceql): fix extract matcher regexes to work with regexp-type matchers #3641
Conversation
bfddfc8
to
d22cbaa
Compare
unsure why the drone CI failed. I have restarted it. can you sign the CLA and add a changelog entry? |
d22cbaa
to
d12fe56
Compare
Hmm I've rebased on main just in case. Signed the CLA and added a changelog entry too 👍 |
…tchers Partially fixes #3635. I'm going to add a further test case which this doesn't fix.
31af1b1
to
1539758
Compare
Drone is failing on the step to test the debian package because tempo isn't starting up. It doesn't seem like it captures the tempo logs. Unlikely to be caused by the changes in this PR, but digging into it. |
I wasn't able to do exact reproduction of the drone steps because of systemd-in-docker woes, but was able to confirm that
|
The drone issues were resolved in #3657 and all looks good. Thanks. |
This improves the regexes used by autocomplete (and I think the search tags v2 endpoint?) so that they work with queries like
{ resource.service.name = "app" && resource.k8s.cluster.name=~"prod-.+" }
.Fixes #3635.