feat: allow symbols as GraphQLSchema extension fields #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for compassionate-pike-271cb3 ready! 🔨 Explore the source changes: 10ba0fa 🔍 Inspect the deploy log: https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6230936702007b00093bc3fa 😎 Browse the preview: https://deploy-preview-3511--compassionate-pike-271cb3.netlify.app |
|
@IvanGoncharov supporting TypeScript 4.3 prevents supporting symbols as index keys (#3511) |
IvanGoncharov
requested changes
Apr 26, 2022
There was a problem hiding this comment.
@n1ru4l Symbols as extensions keys totally make sense.
Please add some basic tests.
As for ObjMap I'm don't understand motivation for this change.
Can you please clarify it?
Thanks for clarification 👍 |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Apr 26, 2022
|
Flagging for v17 |
JoviDeCroock
approved these changes
Sep 28, 2024
JoviDeCroock
added a commit
that referenced
this pull request
Oct 14, 2024
Supersedes #3511 This adds support for `Symbol` property keys on the extension property of AST nodes. Had to tweak `toObjMap` here to support symbol keys by adding `getOwnPropertySymbols` which is the only way to enumerate over them. --------- Co-authored-by: n1ru4l <[email protected]>
|
Part of v17 now |
erikwrede
pushed a commit
to erikwrede/graphql-js
that referenced
this pull request
Oct 17, 2024
Supersedes graphql/graphql-js#3511 This adds support for `Symbol` property keys on the extension property of AST nodes. Had to tweak `toObjMap` here to support symbol keys by adding `getOwnPropertySymbols` which is the only way to enumerate over them. --------- Co-authored-by: n1ru4l <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.