Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node 12 and 17, update rest to latest minor version #3546

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Apr 26, 2022
@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 7754cf6
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6268012725b6d2000869939c
😎 Deploy Preview https://deploy-preview-3546--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@n1ru4l
Copy link
Contributor

n1ru4l commented Apr 26, 2022

@IvanGoncharov Could we also drop support for old TypeScript versions as part of this pull request (typescript-4.3)?

@IvanGoncharov
Copy link
Member Author

@IvanGoncharov Could we also drop support for old TypeScript versions as part of this pull request (typescript-4.3)?

Yes, we could but it's better to keep it in separate PR to improve the changelog.
Do you have any particular TS feature that is not supported in 4.3?
Or do you suggest just supporting "not so old TS versions"?
Both works, are just interested in the context of this proposal.

@IvanGoncharov IvanGoncharov merged commit 5a49295 into graphql:main Apr 26, 2022
@IvanGoncharov IvanGoncharov deleted the pr_branch branch April 26, 2022 16:30
@n1ru4l
Copy link
Contributor

n1ru4l commented Apr 26, 2022

@IvanGoncharov See #3511 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants