Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks for actual deferral #3991

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Nov 21, 2023

depends on #3993

adds judicious explicit checking for the expected extra ticks when fields are deferred.

@robrichard -- these new tests all also pass with #3982 without any changes => review there en route.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4203dda
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/655f9dff855c380008e66500
😎 Deploy Preview https://deploy-preview-3991--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Nov 23, 2023
The publish method checks to see if a subsequent result is empty; this same logic should be employed to suppress pending notices for empty records.

This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.

For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.

This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.
@yaacovCR
Copy link
Contributor Author

yaacovCR commented May 9, 2024

Converting to draft, has to be rebased considering interval changes.

@yaacovCR yaacovCR marked this pull request as draft May 9, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant