Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(incremental): skip all empty subsequent results #3993

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

yaacovCR
Copy link
Contributor

The publish method checks to see if a subsequent result is empty; this same logic should be employed to suppress pending notices for empty records.

This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.

For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.

This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4d783be
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/657ff8571976890008dc532c
😎 Deploy Preview https://deploy-preview-3993--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label Nov 22, 2023
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.

For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.

This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.

This fix slightly reduces test coverage of one branch, which has been fixed in a workaround. TODO: add back missing test case.
@yaacovCR yaacovCR changed the title do not emit pending for empty non-published subsequent results fix(incremental): skip all empty subsequent results Mar 19, 2024
@yaacovCR yaacovCR merged commit ef478a2 into graphql:main Mar 19, 2024
20 checks passed
@yaacovCR yaacovCR deleted the pending-bug-fix branch March 19, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants