Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(incremental): skip all empty subsequent results #3993

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(incremental): skip all empty subsequent results #3993

merged 1 commit into from
Mar 19, 2024

Commits on Dec 18, 2023

  1. don't ever send empty pendings, instead publish the children 

    This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records.

For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing.

This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.

This fix slightly reduces test coverage of one branch, which has been fixed in a workaround. TODO: add back missing test case.
    @yaacovCR
    yaacovCR committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    4d783be View commit details
    Browse the repository at this point in the history