Migrate access/msteams to slog + add debug logs #47045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
commented
Oct 1, 2024
r0mant
approved these changes
Oct 1, 2024
tigrato
approved these changes
Oct 1, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis,
espadolini and
rosstimothy
hugoShaka
commented
Oct 1, 2024
hugoShaka
commented
Oct 1, 2024
hugoShaka
commented
Oct 1, 2024
espadolini
approved these changes
Oct 1, 2024
rosstimothy
reviewed
Oct 1, 2024
hugoShaka
force-pushed
the
hugo/improve-access-msteams-log
branch
from
0c7136b
to
7c0797d
Compare
rosstimothy
approved these changes
Oct 1, 2024
integrations/access/msteams/app.go
Outdated
Comment on lines
177
to
179
| "recipient", recipient, | ||
| "recipient_chat_id", recipientData.Chat.ID, | ||
| "recipient_kind", recipientData.Kind) |
There was a problem hiding this comment.
Might also benefit from a group here
hugoShaka
force-pushed
the
hugo/improve-access-msteams-log
branch
from
7c0797d
to
0e38bd0
Compare
hugoShaka
force-pushed
the
hugo/improve-access-msteams-log
branch
from
0e38bd0
to
6c7f79e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@hugoShaka See the table below for backport results.
|
zmb3
added a commit
that referenced
this pull request
Oct 3, 2024
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo. In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies. Fix the builds by duplicating the constant and avoiding the import.
Merged
zmb3
added a commit
that referenced
this pull request
Oct 3, 2024
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo. In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies. Fix the builds by duplicating the constant and avoiding the import.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo. In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies. Fix the builds by duplicating the constant and avoiding the import.
zmb3
added a commit
that referenced
this pull request
Oct 3, 2024
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo. In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies. Fix the builds by duplicating the constant and avoiding the import.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo. In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies. Fix the builds by duplicating the constant and avoiding the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
changelog: Improve the msteams access plugin debug logging.