Fix plugin builds #47172
Merged
Fix plugin builds #47172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
added
no-changelog
rosstimothy
approved these changes
Oct 3, 2024
rosstimothy
reviewed
Oct 3, 2024
hugoShaka
approved these changes
Oct 3, 2024
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo. In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies. Fix the builds by duplicating the constant and avoiding the import.
zmb3
force-pushed
the
zmb3/fix-plugins-build
branch
from
ccc06c2
to
21a1a5c
Compare
codingllama
reviewed
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins build without CGo, so they can't import (directly or indirectly) any packages that require CGo.
In #47045 we added a lib/config import to pull in a constant, which added a large dependency tree that included CGo dependencies.
Fix the builds by duplicating the constant and avoiding the import.