Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withTableSelection HOC background color fix #1397

Merged
merged 2 commits into from
Mar 5, 2024
Merged

withTableSelection HOC background color fix #1397

merged 2 commits into from
Mar 5, 2024

Conversation

GermanVor
Copy link
Contributor

@GermanVor GermanVor requested a review from Raubzeug as a code owner March 4, 2024 22:15
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@GermanVor
Copy link
Contributor Author

ts does not warn in this place - weird, it should

@GermanVor GermanVor mentioned this pull request Mar 4, 2024
Closed
@Raubzeug
Copy link
Contributor

Raubzeug commented Mar 5, 2024 •
edited
Loading

ts does not warn in this place - weird, it should

It seems that the reason is here... We explicitly point that returned value is of a proper type.

@Raubzeug
Copy link
Contributor

Raubzeug commented Mar 5, 2024

BTW, screenshot test example is here.

@GermanVor GermanVor merged commit 256c153 into main Mar 5, 2024
4 checks passed
@GermanVor GermanVor deleted the withTableSelection-fix branch March 5, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

@Raubzeug Raubzeug Raubzeug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GermanVor @gravity-ui-bot @Raubzeug @korvin89