Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withTableSelection HOC background color fix #1397

Merged
merged 2 commits into from
Mar 5, 2024
Merged

withTableSelection HOC background color fix #1397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10e265f
fix: return correct getRowDescriptor wrapper
Mar 4, 2024
8c6cb05
Merge branch 'main' into withTableSelection-fix
korvin89 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/components/Table/hoc/withTableSelection/withTableSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,20 +203,26 @@ export function withTableSelection<I extends TableDataItem, E extends {} = {}>(
// eslint-disable-next-line @typescript-eslint/member-ordering
private enhanceGetRowDescriptor = _memoize(
(getRowDescriptor?: TableProps<I>['getRowDescriptor']) => {
return (item: I, index: number) => {
const currentGetRowDescriptor: TableProps<I>['getRowDescriptor'] = (
item: I,
index: number,
) => {
const {selectedIds, getRowClassNames} = this.props;
const classNames =
getRowDescriptor?.(item, index)?.classNames?.slice() ||
getRowClassNames?.(item, index) ||
[];
const descriptor = getRowDescriptor?.(item, index) || {};

if (descriptor.classNames === undefined) {
descriptor.classNames = getRowClassNames?.(item, index) || [];
}

const id = Table.getRowId(this.props, item, index);
const selected = selectedIds.includes(id);

classNames.push(b('row', {selected}));
descriptor.classNames.push(b('row', {selected}));

return classNames;
return descriptor;
};

return currentGetRowDescriptor;
},
);

Expand Down
Loading