feat: remove postinstall script, update readme.md #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaShkaruba
commented
Jul 14, 2023
| @@ -18,7 +18,6 @@ | |||
| "types": "./dist/index.d.ts", | |||
| "scripts": { | |||
| "prepare": "husky install", | |||
| "postinstall": "cd src/generator && npm install", | |||
There was a problem hiding this comment.
When we're installing new package, we get a new error
4610 error path /Users/n-shkaruba/Code/websql/node_modules/sql-autocomplete-parsers
4611 error command failed
4612 error command sh -c cd src/generator && npm install
4613 error sh: line 0: cd: src/generator: No such file or directory
4614 verbose exit 1
We don't include src/generator in our build proof, so postinstall doesn't work.
viladimiru
approved these changes
Jul 14, 2023
NikitaShkaruba
commented
Jul 14, 2023
| @@ -59,6 +59,6 @@ jobs: | |||
| node-version: '18.x' | |||
| cache: 'npm' | |||
| - name: Install Packages | |||
| run: npm ci | |||
| run: npm ci && cd src/generator/ && npm ci | |||
There was a problem hiding this comment.
It's not very pretty, but it'll do for now
viladimiru
approved these changes
Jul 14, 2023
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.