Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove postinstall script, update readme.md #53

Merged
merged 2 commits into from
Jul 14, 2023
Merged

feat: remove postinstall script, update readme.md #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf0f97
feat: remove postinstall script, update readme.md
NikitaShkaruba Jul 14, 2023
5defacb
fix: fix CI
NikitaShkaruba Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Resources to research:
4. `src/parsing/parsers/{dialect}/jison/structure.json` specifies paths to a lexer, and to all the grammar files.
5. Parser extension (basically the autocomplete features) is specified in `src/parsing/parsers/{dialect}/parser-extension.js`.
6. `src/generator/main.js` concatenates all the jison files into a single big jison file, and runs the jison tool with the specified lexer, then wires everything up with the `parser-extension.js`, generating `src/parsing/parsers/{dialect}/{dialect}AutocompleteParser.js`.
7. The generated file is in plain javascript, so we create a convenient typescript wrapper in `src/parsing/index.ts` with all the types and functions. Our users should include this file in their own projects (for the time being they need to compile it yourself)
7. The generated file is in plain javascript, so we create a convenient typescript wrapper in `src/parsing/index.ts` with all the types and functions. Our users should include this file in their own projects.

# Main scripts

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"types": "./dist/index.d.ts",
"scripts": {
"prepare": "husky install",
"postinstall": "cd src/generator && npm install",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we're installing new package, we get a new error

4610 error path /Users/n-shkaruba/Code/websql/node_modules/sql-autocomplete-parsers
4611 error command failed
4612 error command sh -c cd src/generator && npm install
4613 error sh: line 0: cd: src/generator: No such file or directory
4614 verbose exit 1

We don't include src/generator in our build proof, so postinstall doesn't work.

"test": "npm run generate && npm run test_without_generate",
"test_without_generate": "jest src/parsing",
"generate": "cd src/generator && node main.js generic",
Expand Down
Loading