Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schools and kindergartens mapped as a node not shown anymore. #3876

Closed
A67-A67 opened this issue Sep 7, 2019 · 4 comments · Fixed by #3878
Closed

Schools and kindergartens mapped as a node not shown anymore. #3876

A67-A67 opened this issue Sep 7, 2019 · 4 comments · Fixed by #3878
Assignees
Labels

Comments

@A67-A67
Copy link

A67-A67 commented Sep 7, 2019

Since a few days schools and kindergartens that have been mapped on a node are not shown anymore. This seems to be a bug issue 3868.

Schools are often mapped as an area that contains the entire school area, but in a case of multiple schools sharing a building or a school and a library in the same building building mapping them on a node makes more sense.

Expected behavior

The name of the school or kindergarten is shown in a dark-yellow italic font, like until a few days ago.

Actual behavior

The housenumber is shown instead of the name.

Links and screenshots illustrating the problem

For both the name used to be rendered by OSM-carto. This problem is also being discussed on the Dutch forum, in a discussion that started with issue 3860.

@imagico
Copy link
Collaborator

imagico commented Sep 7, 2019

I have not checked but from a quick look it seems like #3764 removed rendering of this and other POI types by requiring a non-NULL way_pixels value.

@imagico imagico added the bug label Sep 7, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 8, 2019

Thank you, it's correct that #3764 created this, since way_pixels = null is not considered <= 768,000. I've got a PR to fix it.

@jeisenbe jeisenbe added this to the Bugs and improvements milestone Sep 8, 2019
@jeisenbe jeisenbe self-assigned this Sep 8, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 8, 2019

I notice that place=island and place=islet on nodes have not been rendered since PR #1444 in commit 6cd5b3c "Do not render island/islet name when way_pixels is big" in on Sat Mar 21, 2015 - but this appears to have been unintentional? @sommerluk?
I will also restore the rendering for these two features when mapped as nodes at >z16/z17, if there's no objection.

@sommerluk
Copy link
Collaborator

I'm sorry for inconvenience, indeed this was unintentional.

jeisenbe added a commit that referenced this issue Sep 20, 2019
* Restore rendering of landcover and island text labels on points
* Select way_pixels as 0 if way_area is null

Prior to #3764 most features in `landcover` had text labels rendered at high zoom level when tagged on nodes, the same as very small areas. This PR restores this rendering by setting way_pixels to 0 if way_area is null, so points are treated the same as tiny polygons. Fixes #3876
and #3868 and related bugs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants