Stop label rendering for too big areas #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijsmelissen
approved these changes
Apr 24, 2019
jeisenbe
added a commit
to jeisenbe/openstreetmap-carto
that referenced
this pull request
Sep 8, 2019
Prior to gravitystorm#3764 most features in `landcover` had text labels rendered at high zoom level when tagged on nodes. This PR restores this rendering by adding a check for way_pixels=null. Suprisingly, way_pixels != null has to be checked or else the points render with the large lancover text size
jeisenbe
added a commit
that referenced
this pull request
Sep 20, 2019
* Restore rendering of landcover and island text labels on points * Select way_pixels as 0 if way_area is null Prior to #3764 most features in `landcover` had text labels rendered at high zoom level when tagged on nodes, the same as very small areas. This PR restores this rendering by setting way_pixels to 0 if way_area is null, so points are treated the same as tiny polygons. Fixes #3876 and #3868 and related bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028
For various areas, we start label rendering not at a fixed zoom level, but based on the area of the feature. Bigger features get rendered yet on earlier zoom levels.
Furthermore, the size of the label usually gets bigger when the zoom level raises and so the feature occupies more space on the screen.
Since a while, we want to stop label rendering for very big areas that cover the hole screen because the label is quite useless at this scale. However this was not possible in the past because of a bug in our software stack. The bug has been fixed, so now we can do this. (See #1028)
Changes proposed in this pull request:
Test rendering with links to the example places:
(Left: After / Right: Before)
