Fix rendering of water body labels #3919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix PR for water body labels.
Changes proposed in this pull request:
natural_bay
has rendering rules both inamenity-points.mss
(rendering a label in regular font) andwater.mss
(rendering a label in italic font). Consider the Baie des sirènes: The label is rendered in a regular font up to z16, but starting from z17 with an italic font. This PR puts all the rendering rules fornatural_bay
at the same place and unifies the font face (using italic).water.mss
there is almost duplicate code fornatural_strait
. This PR unifies the code in one single block.The XML code that Carto produces decreases slightly with this PR.