fix: adjust Dependency Review action to upstream breaking change #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Conventional Commits Report
🚀 Conventional commits found. |
y0urself
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Thank you for your contribution @mgoetzegb ... would it be "too much" to ask you to also sort the list of allowed dependencies? That would be awesome ... thank you!
1 task
No problem, I already had the licenses sorted locally, but I thought it is good to have this in a separate commit and was concerned that the auto merge feature will just squash it without asking. But I see it is set to |
The github dependency review action no longer allows to pass in logically connected licenses. So if there is a `License-A AND License-B` in the list of allowed licenses, the action will always fail if a dependency has only `License-A` or `License B`. For reference see: actions/dependency-review-action#792 This results in false positives for dependencies with something like `License-A AND License-B`, however as this is much rarer than e.g. `MIT` license, it is preferable to pass on all the single licenses.
y0urself
force-pushed
the
only-single-licenses
branch
from
20c20b3
to
9b4f8bb
Compare
y0urself
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove all entries from the allow licenses of the Dependency Review action which are not a single license, but have the pattern
License-A AND License-BorLicense-A OR License-B.Why
The github dependency review action no longer allows to pass in logically connected licenses. So if there is a
License-A AND License-Bin the list of allowed licenses, the action will always fail if a dependency has onlyLicense-AorLicense B.This results in false positives for dependencies with something like
License-A AND License-B, however as this is much rarer than e.g.MITlicense, it is preferable to pass on all the single licenses.References
Github Action Issue: actions/dependency-review-action#792