Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Allow Unlicense/MIT license #820

Closed
wants to merge 1 commit into from
Closed

Add: Allow Unlicense/MIT license #820

wants to merge 1 commit into from

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Sep 7, 2023

What

Add: Allow Unlicense/MIT license

Why

Required by walkdir

Licenses
  Warning: 
  The validity of the licenses of the dependencies below could not be determined. Ensure that they are valid SPDX licenses:
  rust/Cargo.lock » [email protected] – License: Unlicense/MIT
  Error: Dependency review could not detect the validity of all licenses.

References

Checklist

  • Tests

@jjnicola jjnicola requested a review from a team as a code owner September 7, 2023 10:01
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

y0urself
y0urself reviewed Sep 8, 2023
View reviewed changes
dependency-review/action.yml
@@ -42,4 +42,5 @@ runs:
MIT OR Apache-2.0,
MIT AND Python-2.0,
(Apache-2.0 AND BSD-3-Clause) OR (Apache-2.0 AND MIT),
(MIT OR Apache-2.0) AND Unicode-DFS-2016
(MIT OR Apache-2.0) AND Unicode-DFS-2016,
Unlicense/MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjnicola I don't think this is in the correct format and can not be recognized by the action ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, https://github.com/BurntSushi/walkdir can be licensed under either Unlicense or MIT (see https://github.com/BurntSushi/walkdir/blob/master/README.md?plain=1#L11 ), both of which are already in the list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem is rather that walkdir uses a non-SPDX-compliant identifier for its license. The correct identifier should be Unlicense OR MIT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! Nevertheless, this can not be "fixed" on our side!

@greenbonebot greenbonebot enabled auto-merge (squash) September 25, 2023 07:26
@y0urself
Copy link
Member

@jjnicola did you get approval for this license?

@y0urself
Copy link
Member

@greenbone/scanner-maintainers is this still required? Did you get approval?

@nichtsfrei
Copy link
Member

nichtsfrei commented Jan 31, 2024 •
edited
Loading

what approval? we still need that notation https://github.com/BurntSushi/walkdir/blob/master/Cargo.toml#L12 , yes.

It is fair to assume that the author doesn't seem to care about SPDX-compliant notations as there is a PR open since 2021:
BurntSushi/walkdir#155

@y0urself
Copy link
Member

This will currently not work anyway, as logically connected licenses are not a thing anymore, see #1197

@y0urself y0urself closed this Jul 31, 2024
auto-merge was automatically disabled July 31, 2024 06:22

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm left review comments

@y0urself y0urself y0urself left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjnicola @y0urself @nichtsfrei @wiegandm