Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Allow Unlicense/MIT license #820

Closed
wants to merge 1 commit into from
Closed

Add: Allow Unlicense/MIT license #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dependency-review/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,5 @@ runs:
MIT OR Apache-2.0,
MIT AND Python-2.0,
(Apache-2.0 AND BSD-3-Clause) OR (Apache-2.0 AND MIT),
(MIT OR Apache-2.0) AND Unicode-DFS-2016
(MIT OR Apache-2.0) AND Unicode-DFS-2016,
Unlicense/MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjnicola I don't think this is in the correct format and can not be recognized by the action ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, https://github.com/BurntSushi/walkdir can be licensed under either Unlicense or MIT (see https://github.com/BurntSushi/walkdir/blob/master/README.md?plain=1#L11 ), both of which are already in the list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem is rather that walkdir uses a non-SPDX-compliant identifier for its license. The correct identifier should be Unlicense OR MIT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! Nevertheless, this can not be "fixed" on our side!

Loading