Merge pull request #404 from gridap/fe_space_with_dof_potentially_rem…

…oved Fe space with dof potentially removed (pending changes from PR #396)
gridap · Sep 12, 2020 · c1e0e6a · c1e0e6a
2 parents 5faa6e0 + bcaead3
commit c1e0e6a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,10 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased 
+## [0.14.1] 
 
 ### Added
- - Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/)
+ - Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/).
+
+### Deprecated
+ - The name FESpaceWithLastDofRemoved has been deprecated in favor of its generalization FESpaceWithConstantFixed. Since PR [#396](https://github.com/gridap/Gridap.jl/pull/396) and PR [#404](https://github.com/gridap/Gridap.jl/pull/404).
 
 ## [0.14.0] - 2020-08-27
 

diff --git a/src/FESpaces/FESpaces.jl b/src/FESpaces/FESpaces.jl
@@ -205,6 +205,7 @@ export collect_cell_jacobian_and_residual
 export collect_cell_residual
 
 export FESpaceWithConstantFixed
+export FESpaceWithLastDofRemoved
 
 export ZeroMeanFESpace
 export CLagrangianFESpace

diff --git a/src/FESpaces/FESpacesWithConstantFixed.jl b/src/FESpaces/FESpacesWithConstantFixed.jl
@@ -30,6 +30,13 @@ struct FESpaceWithConstantFixed{CS,CA<:ConstantApproach} <: SingleFieldFESpace
   end
 end
 
+
+const FESpaceWithLastDofRemoved{CS} = FESpaceWithConstantFixed{CS,FixConstant}
+
+@deprecate(FESpaceWithLastDofRemoved(space::SingleFieldFESpace),
+           FESpaceWithConstantFixed(space,true))
+
+
 # Genuine functions
 function num_free_dofs(f::FESpaceWithConstantFixed{CS,FixConstant}) where {CS}
   num_free_dofs(f.space)-1