Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fe space with dof potentially removed (pending changes from PR #396) #404

Merged
merged 4 commits into from
Sep 12, 2020

Conversation

amartinhuertas
Copy link
Member

Pending changes resulting from the discussion in PR #396

@codecov-commenter
Copy link

Codecov Report

Merging #404 into master will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   87.26%   88.50%   +1.24%     
==========================================
  Files         158      158              
  Lines       11092    10147     -945     
==========================================
- Hits         9679     8981     -698     
+ Misses       1413     1166     -247     
Impacted Files Coverage Δ
src/FESpaces/FESpaces.jl 100.00% <ø> (ø)
src/FESpaces/FESpacesWithConstantFixed.jl 80.00% <ø> (+4.65%) ⬆️
src/FESpaces/FECellBases.jl 33.33% <0.00%> (-23.81%) ⬇️
src/Arrays/SubVectors.jl 80.00% <0.00%> (-20.00%) ⬇️
src/Integration/Quadratures.jl 70.00% <0.00%> (-11.82%) ⬇️
src/Arrays/ArrayPairs.jl 81.81% <0.00%> (-11.04%) ⬇️
src/TensorValues/SymFourthOrderTensorValueTypes.jl 64.44% <0.00%> (-10.56%) ⬇️
src/TensorValues/TensorValueTypes.jl 66.66% <0.00%> (-10.15%) ⬇️
src/FESpaces/DirichletFESpaces.jl 90.90% <0.00%> (-9.10%) ⬇️
src/TensorValues/SymTensorValueTypes.jl 56.71% <0.00%> (-8.57%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df737b8...bcaead3. Read the comment docs.

@fverdugo fverdugo merged commit c1e0e6a into master Sep 12, 2020
@fverdugo fverdugo deleted the fe_space_with_dof_potentially_removed branch September 12, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants