Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fe space with dof potentially removed (pending changes from PR #396) #404

Merged
merged 4 commits into from
Sep 12, 2020
Merged

Fe space with dof potentially removed (pending changes from PR #396) #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
462b375
Added FESpaceWithLastDofRemoved alias for backward compatibility
amartinhuertas Sep 11, 2020
ff129f5
Added necessary lines of code to keep the old FESpaceWithDofRemoved
amartinhuertas Sep 12, 2020
70efeb4
Fixed syntax error from ff129f5594d3fcf76965076c84b878c46d349a34
amartinhuertas Sep 12, 2020
bcaead3
Update NEWS.md
amartinhuertas Sep 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
## [0.14.1]

### Added
- Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/)
- Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/).

### Deprecated
- The name FESpaceWithLastDofRemoved has been deprecated in favor of its generalization FESpaceWithConstantFixed. Since PR [#396](https://github.com/gridap/Gridap.jl/pull/396) and PR [#404](https://github.com/gridap/Gridap.jl/pull/404).

## [0.14.0] - 2020-08-27

Expand Down
1 change: 1 addition & 0 deletions src/FESpaces/FESpaces.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ export collect_cell_jacobian_and_residual
export collect_cell_residual

export FESpaceWithConstantFixed
export FESpaceWithLastDofRemoved

export ZeroMeanFESpace
export CLagrangianFESpace
Expand Down
7 changes: 7 additions & 0 deletions src/FESpaces/FESpacesWithConstantFixed.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ struct FESpaceWithConstantFixed{CS,CA<:ConstantApproach} <: SingleFieldFESpace
end
end


const FESpaceWithLastDofRemoved{CS} = FESpaceWithConstantFixed{CS,FixConstant}

@deprecate(FESpaceWithLastDofRemoved(space::SingleFieldFESpace),
FESpaceWithConstantFixed(space,true))


# Genuine functions
function num_free_dofs(f::FESpaceWithConstantFixed{CS,FixConstant}) where {CS}
num_free_dofs(f.space)-1
Expand Down