Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding x86 to gh actions #456

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Adding x86 to gh actions #456

merged 3 commits into from
Nov 17, 2020

Conversation

amartinhuertas
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #456 (8535df5) into master (23f56ed) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   87.32%   87.30%   -0.02%     
==========================================
  Files         158      158              
  Lines       11170    11172       +2     
==========================================
  Hits         9754     9754              
- Misses       1416     1418       +2     
Impacted Files Coverage Δ
src/Io/Json.jl 100.00% <100.00%> (ø)
src/Arrays/CachedArrays.jl 79.31% <0.00%> (-1.40%) ⬇️
src/Arrays/Tables.jl 90.00% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f56ed...8535df5. Read the comment docs.

@fverdugo fverdugo merged commit 14999d8 into master Nov 17, 2020
@fverdugo
Copy link
Member

@amartinhuertas perhaps we could run with x86 only in master and in PR against master.

The test suite is quite heavy and running x86 in all work branches is perhaps too much...

What do you think?

@amartinhuertas
Copy link
Member Author

@amartinhuertas perhaps we could run with x86 only in master and in PR against master.

The test suite is quite heavy and running x86 in all work branches is perhaps too much...

What do you think?

Yes, I agree, no need to perform x86 on all branches. I will do it.

@amartinhuertas
Copy link
Member Author

Yes, I agree, no need to perform x86 on all branches. I will do it.

Done in #461!

@amartinhuertas amartinhuertas deleted the adding_x86_to_gh_actions branch August 19, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants