Skip to content

Commit

Permalink
deps: update maps to 2021-02-01, add G2 SKU (hashicorp#11676)
Browse files Browse the repository at this point in the history
Fixes hashicorp#11610

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/maps -timeout=1000m
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccMapsAccountDataSource_basic
=== PAUSE TestAccMapsAccountDataSource_basic
=== RUN   TestAccMapsAccount_basic
=== PAUSE TestAccMapsAccount_basic
=== RUN   TestAccMapsAccount_sku
=== PAUSE TestAccMapsAccount_sku
=== RUN   TestAccMapsAccount_skuG2
=== PAUSE TestAccMapsAccount_skuG2
=== RUN   TestAccMapsAccount_tags
=== PAUSE TestAccMapsAccount_tags
=== CONT  TestAccMapsAccountDataSource_basic
=== CONT  TestAccMapsAccount_skuG2
=== CONT  TestAccMapsAccount_tags
=== CONT  TestAccMapsAccount_sku
=== CONT  TestAccMapsAccount_basic
--- PASS: TestAccMapsAccountDataSource_basic (103.35s)
--- PASS: TestAccMapsAccount_basic (106.81s)
--- PASS: TestAccMapsAccount_sku (108.20s)
--- PASS: TestAccMapsAccount_skuG2 (109.10s)
--- PASS: TestAccMapsAccount_tags (157.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/maps	158.883s
```
  • Loading branch information
favoretti committed May 26, 2021
1 parent ba64d50 commit b1db8aa
Show file tree
Hide file tree
Showing 16 changed files with 2,039 additions and 442 deletions.
2 changes: 1 addition & 1 deletion azurerm/internal/services/maps/client/client.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package client

import (
"github.com/Azure/azure-sdk-for-go/services/maps/mgmt/2018-05-01/maps"
"github.com/Azure/azure-sdk-for-go/services/maps/mgmt/2021-02-01/maps"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/common"
)

Expand Down
2 changes: 1 addition & 1 deletion azurerm/internal/services/maps/maps_account_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func dataSourceMapsAccountRead(d *schema.ResourceData, meta interface{}) error {
d.Set("sku_name", sku.Name)
}
if props := resp.Properties; props != nil {
d.Set("x_ms_client_id", props.XMsClientID)
d.Set("x_ms_client_id", props.UniqueID)
}

keysResp, err := client.ListKeys(ctx, resourceGroup, name)
Expand Down
13 changes: 7 additions & 6 deletions azurerm/internal/services/maps/maps_account_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"log"
"time"

"github.com/Azure/azure-sdk-for-go/services/maps/mgmt/2018-05-01/maps"
"github.com/Azure/azure-sdk-for-go/services/maps/mgmt/2021-02-01/maps"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
Expand Down Expand Up @@ -53,8 +53,9 @@ func resourceMapsAccount() *schema.Resource {
Required: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
"S0",
"S1",
string(maps.NameS0),
string(maps.NameS1),
string(maps.NameG2),
}, false),
},

Expand Down Expand Up @@ -105,10 +106,10 @@ func resourceMapsAccountCreateUpdate(d *schema.ResourceData, meta interface{}) e
}
}

parameters := maps.AccountCreateParameters{
parameters := maps.Account{
Location: utils.String("global"),
Sku: &maps.Sku{
Name: &sku,
Name: maps.Name(sku),
},
Tags: tags.Expand(t),
}
Expand Down Expand Up @@ -157,7 +158,7 @@ func resourceMapsAccountRead(d *schema.ResourceData, meta interface{}) error {
d.Set("sku_name", sku.Name)
}
if props := resp.Properties; props != nil {
d.Set("x_ms_client_id", props.XMsClientID)
d.Set("x_ms_client_id", props.UniqueID)
}

keysResp, err := client.ListKeys(ctx, id.ResourceGroup, id.Name)
Expand Down
27 changes: 23 additions & 4 deletions azurerm/internal/services/maps/maps_account_resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestAccMapsAccount_sku(t *testing.T) {

data.ResourceTest(t, r, []resource.TestStep{
{
Config: r.sku(data),
Config: r.sku(data, "S1"),
Check: resource.ComposeTestCheckFunc(
check.That(data.ResourceName).Key("name").Exists(),
check.That(data.ResourceName).Key("x_ms_client_id").Exists(),
Expand All @@ -55,6 +55,25 @@ func TestAccMapsAccount_sku(t *testing.T) {
})
}

func TestAccMapsAccount_skuG2(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_maps_account", "test")
r := MapsAccountResource{}

data.ResourceTest(t, r, []resource.TestStep{
{
Config: r.sku(data, "G2"),
Check: resource.ComposeTestCheckFunc(
check.That(data.ResourceName).Key("name").Exists(),
check.That(data.ResourceName).Key("x_ms_client_id").Exists(),
check.That(data.ResourceName).Key("primary_access_key").Exists(),
check.That(data.ResourceName).Key("secondary_access_key").Exists(),
check.That(data.ResourceName).Key("sku_name").HasValue("G2"),
),
},
data.ImportStep(),
})
}

func TestAccMapsAccount_tags(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_maps_account", "test")
r := MapsAccountResource{}
Expand Down Expand Up @@ -113,7 +132,7 @@ resource "azurerm_maps_account" "test" {
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger)
}

func (MapsAccountResource) sku(data acceptance.TestData) string {
func (MapsAccountResource) sku(data acceptance.TestData, sku string) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
Expand All @@ -127,9 +146,9 @@ resource "azurerm_resource_group" "test" {
resource "azurerm_maps_account" "test" {
name = "accMapsAccount-%d"
resource_group_name = azurerm_resource_group.test.name
sku_name = "S1"
sku_name = "%s"
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger)
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, sku)
}

func (MapsAccountResource) tags(data acceptance.TestData) string {
Expand Down

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b1db8aa

Please sign in to comment.