Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update maps to 2021-02-01, add G2 SKU #11676

Merged
merged 1 commit into from
May 13, 2021
Merged

deps: update maps to 2021-02-01, add G2 SKU #11676

merged 1 commit into from
May 13, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #11610

$ TF_ACC=1 go test -v ./azurerm/internal/services/maps -timeout=1000m
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccMapsAccountDataSource_basic
=== PAUSE TestAccMapsAccountDataSource_basic
=== RUN   TestAccMapsAccount_basic
=== PAUSE TestAccMapsAccount_basic
=== RUN   TestAccMapsAccount_sku
=== PAUSE TestAccMapsAccount_sku
=== RUN   TestAccMapsAccount_skuG2
=== PAUSE TestAccMapsAccount_skuG2
=== RUN   TestAccMapsAccount_tags
=== PAUSE TestAccMapsAccount_tags
=== CONT  TestAccMapsAccountDataSource_basic
=== CONT  TestAccMapsAccount_skuG2
=== CONT  TestAccMapsAccount_tags
=== CONT  TestAccMapsAccount_sku
=== CONT  TestAccMapsAccount_basic
--- PASS: TestAccMapsAccountDataSource_basic (103.35s)
--- PASS: TestAccMapsAccount_basic (106.81s)
--- PASS: TestAccMapsAccount_sku (108.20s)
--- PASS: TestAccMapsAccount_skuG2 (109.10s)
--- PASS: TestAccMapsAccount_tags (157.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/maps	158.883s

Fixes #11610

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/maps -timeout=1000m
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccMapsAccountDataSource_basic
=== PAUSE TestAccMapsAccountDataSource_basic
=== RUN   TestAccMapsAccount_basic
=== PAUSE TestAccMapsAccount_basic
=== RUN   TestAccMapsAccount_sku
=== PAUSE TestAccMapsAccount_sku
=== RUN   TestAccMapsAccount_skuG2
=== PAUSE TestAccMapsAccount_skuG2
=== RUN   TestAccMapsAccount_tags
=== PAUSE TestAccMapsAccount_tags
=== CONT  TestAccMapsAccountDataSource_basic
=== CONT  TestAccMapsAccount_skuG2
=== CONT  TestAccMapsAccount_tags
=== CONT  TestAccMapsAccount_sku
=== CONT  TestAccMapsAccount_basic
--- PASS: TestAccMapsAccountDataSource_basic (103.35s)
--- PASS: TestAccMapsAccount_basic (106.81s)
--- PASS: TestAccMapsAccount_sku (108.20s)
--- PASS: TestAccMapsAccount_skuG2 (109.10s)
--- PASS: TestAccMapsAccount_tags (157.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/maps	158.883s
```
@favoretti
Copy link
Collaborator Author

Oh, I seem to have missed #11616.. I believe XMsClientId has turned from:

// AccountProperties additional Map account properties
type AccountProperties struct {
	// XMsClientID - A unique identifier for the maps account
	XMsClientID *string `json:"x-ms-client-id,omitempty"`
}

to UniqueID

type AccountProperties struct {
	// UniqueID - READ-ONLY; A unique identifier for the maps account
	UniqueID *string `json:"uniqueId,omitempty"`
	// DisableLocalAuth - Allows toggle functionality on Azure Policy to disable Azure Maps local authentication support. This will disable Shared Keys authentication from any usage.
	DisableLocalAuth *bool `json:"disableLocalAuth,omitempty"`
	// ProvisioningState - READ-ONLY; the state of the provisioning.
	ProvisioningState *string `json:"provisioningState,omitempty"`
}

which I updated in my PR accordingly.

@katbyte katbyte added this to the v2.59.0 milestone May 13, 2021
@katbyte katbyte mentioned this pull request May 13, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte merged commit 5eae63e into hashicorp:master May 13, 2021
katbyte added a commit that referenced this pull request May 13, 2021
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

favoretti added a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
Fixes hashicorp#11610

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/maps -timeout=1000m
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
2021/05/12 12:36:22 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccMapsAccountDataSource_basic
=== PAUSE TestAccMapsAccountDataSource_basic
=== RUN   TestAccMapsAccount_basic
=== PAUSE TestAccMapsAccount_basic
=== RUN   TestAccMapsAccount_sku
=== PAUSE TestAccMapsAccount_sku
=== RUN   TestAccMapsAccount_skuG2
=== PAUSE TestAccMapsAccount_skuG2
=== RUN   TestAccMapsAccount_tags
=== PAUSE TestAccMapsAccount_tags
=== CONT  TestAccMapsAccountDataSource_basic
=== CONT  TestAccMapsAccount_skuG2
=== CONT  TestAccMapsAccount_tags
=== CONT  TestAccMapsAccount_sku
=== CONT  TestAccMapsAccount_basic
--- PASS: TestAccMapsAccountDataSource_basic (103.35s)
--- PASS: TestAccMapsAccount_basic (106.81s)
--- PASS: TestAccMapsAccount_sku (108.20s)
--- PASS: TestAccMapsAccount_skuG2 (109.10s)
--- PASS: TestAccMapsAccount_tags (157.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/maps	158.883s
```
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_maps_account unable to create gen2 pricing tier
2 participants