The logic for 'in' is incorrect

[fivesmallq]

version: growthbook-c-sharp 1.0.0

When I was dealing with conditions involving 'in', I found that the results were not as expected.
I suspect that during the check for whether an element is contained in an array, the ToString method converted the array into a string type, and then it was processed using string methods.

see different:

growthbook-c-sharp/GrowthBook/Providers/ConditionEvaluationProvider.cs

Line 391 in 57b6b0b

return conditionValue.ToString().Contains(actualValue.ToString());

growthbook-c-sharp/GrowthBook/Utilities.cs

Line 388 in 70ea9f4

return conditionList.FirstOrDefault(j => j.ToString().Equals(attributeValue?.ToString())) != null;

test code:

[TestMethod]
        public void TestFeature()
        {
            var featureString = """
                                {
                                  "defaultValue": false,
                                  "rules": [
                                    {
                                      "condition": {
                                        "userId": {
                                          "$in": [
                                            "ac1",
                                            "ac2",
                                            "ac3"
                                          ]
                                        }
                                      },
                                      "force": true
                                    }
                                  ]
                                }
                                """;
            var feature = JsonConvert.DeserializeObject<Feature>(featureString);
            var staticFeatures = new Dictionary<string, Feature>
            {
                {
                    "test-in-op", feature
                }
            };
            var context = new Context
            {
                Enabled = true,
                Url = "",
                Features = staticFeatures
            };

            var growthBook = new GrowthBook.GrowthBook(context);
            var flag = growthBook.IsOn("test-in-op");
            Assert.IsFalse(flag);
            
            // set userId
            context.Attributes.Add("userId", "");
            var errorFlag = growthBook.IsOn("test-in-op");
            Assert.IsFalse(errorFlag); // assert failed, it should be false
        }

[Norhaven]

@fivesmallq Good catch, thanks! It was correctly identifying both cases as not having an actual array value, but only did a null check on the value prior to comparison which meant that an empty string value would pass and would then be found within the subsequent string comparison. Should be fixed with the PR above.