Fixed differing null/empty evaluation during non-array IsIn condition #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of the
ConditionEvaluationProvider.IsIn()
call was incorrectly checking for only a null value when a non-array actual value was present, which made the behavior mark features as enabled when they should have been disabled. Changed this to do an actualIsNullOrWhitespace()
verification on the non-array token instead to fix the issue.This PR is to address issue #24.