api: Stabilize io.grpc.CallCredentials (#10208)

grpc · May 22, 2023 · dd2dc21 · dd2dc21
1 parent 478f30e
commit dd2dc21
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 16 deletions.
diff --git a/api/src/main/java/io/grpc/CallCredentials.java b/api/src/main/java/io/grpc/CallCredentials.java
@@ -56,18 +56,19 @@ public abstract void applyRequestMetadata(
       RequestInfo requestInfo, Executor appExecutor, CallCredentials.MetadataApplier applier);
 
   /**
-   * Should be a noop but never called; tries to make it clearer to implementors that they may break
-   * in the future.
+   * With this class now being stable this method moves from an abstract one to a normal one with
+   * a no-op implementation. This method is marked deprecated to allow extenders time to remove the
+   * method before it is removed here.
    */
-  @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1914")
-  public abstract void thisUsesUnstableApi();
+  @Deprecated
+  public void thisUsesUnstableApi() {
+  }
 
   /**
    * The outlet of the produced headers. Not thread-safe.
    *
    * <p>Exactly one of its methods must be called to make the RPC proceed.
    */
-  @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1914")
   public abstract static class MetadataApplier {
     /**
      * Called when headers are successfully generated. They will be merged into the original
@@ -84,7 +85,6 @@ public abstract static class MetadataApplier {
   /**
    * The request-related information passed to {@code CallCredentials.applyRequestMetadata()}.
    */
-  @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1914")
   public abstract static class RequestInfo {
     /**
      * The method descriptor of this RPC.

diff --git a/api/src/main/java/io/grpc/CompositeCallCredentials.java b/api/src/main/java/io/grpc/CompositeCallCredentials.java
@@ -40,9 +40,6 @@ public void applyRequestMetadata(
         new WrappingMetadataApplier(requestInfo, appExecutor, applier, Context.current()));
   }
 
-  @Override
-  public void thisUsesUnstableApi() {}
-
   private final class WrappingMetadataApplier extends MetadataApplier {
     private final RequestInfo requestInfo;
     private final Executor appExecutor;

diff --git a/api/src/test/java/io/grpc/CompositeCallCredentialsTest.java b/api/src/test/java/io/grpc/CompositeCallCredentialsTest.java
@@ -109,7 +109,5 @@ public FakeCallCredentials(Status status) {
         applier.fail(status);
       }
     }
-
-    @Override public void thisUsesUnstableApi() {}
   }
 }
diff --git a/auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java b/auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java
@@ -94,9 +94,6 @@ public GoogleAuthLibraryCallCredentials(Credentials creds) {
     }
   }
 
-  @Override
-  public void thisUsesUnstableApi() {}
-
   @Override
   public void applyRequestMetadata(
       RequestInfo info, Executor appExecutor, final MetadataApplier applier) {

diff --git a/core/src/test/java/io/grpc/internal/FakeCallCredentials.java b/core/src/test/java/io/grpc/internal/FakeCallCredentials.java
@@ -38,6 +38,4 @@ public void applyRequestMetadata(
       CallCredentials.MetadataApplier applier) {
     applier.apply(headers);
   }
-
-  @Override public void thisUsesUnstableApi() {}
 }