Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Stabilize io.grpc.CallCredentials #10208

Merged
merged 2 commits into from
May 22, 2023

Conversation

temawi
Copy link
Contributor

@temawi temawi commented May 19, 2023

Removes the @ExperimentalApi annotation from the class and provides an empty implementation for the thisUsesUnstableApi() method.

@temawi temawi requested a review from larry-safran May 19, 2023 20:48
@temawi
Copy link
Contributor Author

temawi commented May 19, 2023

cc: @ejona86

Copy link
Contributor

@larry-safran larry-safran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put a note in issues/1914 to remove the method and schedule closing the issue for 1.57

@temawi temawi merged commit dd2dc21 into grpc:master May 22, 2023
@temawi
Copy link
Contributor Author

temawi commented May 22, 2023

You should put a note in issues/1914 to remove the method and schedule closing the issue for 1.57

I made a note on that issue that the class is stabilized and that the method is deprecated. The issue is still open, but I did not specifically schedule it for 1.57 yet. How do we determine that that is sufficient time for people to stop using the method?

@ejona86
Copy link
Member

ejona86 commented May 22, 2023

Let's preserve the @ExperimentalApi annotation on the thisUsesUnstableApi() method, to make it clear we can remove the method.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants