-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: Treat IOExceptions as UNAVAILABLE #3757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any risk of back-porting. It's a question about how bad we want it in 1.8.x.
metadata = creds.getRequestMetadata(uri); | ||
} catch (IOException e) { | ||
// Since it's an I/O failure, let the call be retried with UNAVAILABLE. | ||
applier.fail(Status.UNAVAILABLE.withCause(e)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point. Done.
Fixes #3267
Should we backport this to 1.8?
CC @buchgr