auth: Use async version of getRequestMetadata #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
force-pushed
the
auth-async
branch
2 times, most recently
from
e8ce453
to
ef49437
Compare
zhangkun83
reviewed
Nov 17, 2017
| try { | ||
| lastHeaders = toHeaders(metadata); | ||
| } catch (Throwable t) { | ||
| applier.fail(Status.UNAUTHENTICATED.withCause(t)); |
There was a problem hiding this comment.
If you put try-catch outside of synchronized, you should be able to call applier.fail() without holding the lock.
| firstNonNull(callOptions.getExecutor(), appExecutor), applier); | ||
| try { | ||
| creds.applyRequestMetadata(method, effectiveAttrsBuilder.build(), | ||
| firstNonNull(callOptions.getExecutor(), appExecutor), applier); |
There was a problem hiding this comment.
applyRequestMetadata() is not supposed to throw. Errors should be passed to the applier.
There was a problem hiding this comment.
Since this is user-provided code, I don't feel like that negates the need to handle exceptions from the call. It's too easy for a NPE or similar to leak through. I've adding a message to the status to make it clearer the code did something wrong.
|
I'm going to need to rebase on top of #3757. When I do that I'll also update the Statuses to make sure they descriptions. |
zhangkun83
approved these changes
Nov 17, 2017
This avoids using DelayedStream and a thread hop when the credentials are known immediately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids using DelayedStream and a thread hop when the credentials
are known immediately.
This is dependent on #3757.