core,okhttp: handle unresolved proxy addresses #3789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a NullPointerException in OkHttpClientTransport when the proxy returns an unresolved address, in which case
InetSocketAddress#getAddress
will return null. This also changes theGRPC_PROXY_EXP
handling to explicitly return an unresolvedInetSocketAddress
to avoid I/O at channel creation. Our other uses of theInetSocketAddress(String, int)
constructor are all in tests or interop/benchmark clients, and as far as I can tell not problematic.@ejona86 Should this fix (modified to the pre-
ProxySelector
code) be backported? If so, to which releases?