-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Resolve address of GRPC_PROXY_EXP hostname #4027
Conversation
Since this address is never resolved gRPC fails to connect with an UnresolvedAddressException when the env variable is specified. This should resolve the address before we attempt to proxy to it.
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
CLA signed |
As discussed elsewhere, we really don't want to do DNS lookups here, but we were before and without it things are broken. The real solution will need to plumb the proxy address through the name resolver. That is being tracked by #4029. |
Oh, and to be clear why we don't want to do DNS lookups here: it is triggered during static initialization. The code before ProxySelector resolved DNS when the builder was built, which was also sub-optimal. |
For posterity, this reverts part of #3789. |
Since this address is never resolved gRPC fails to connect with an
UnresolvedAddressException when the env variable is specified. This
should resolve the address before we attempt to proxy to it.
I know this env variable is scheduled to be removed, so if that's happening in the next version I guess this fix probably isn't necessary.
Also not sure whether there's a good reason why we don't make a DNS lookup here (c.f. comment), but I couldn't find anywhere down the pipeline where this would otherwise get resolved.