all: migrate gradle build to java-library plugin #6902

dapengzhang0 · 2020-04-05T18:59:59Z

Use gradle configuration api for dependencies that are part of grpc public api signatures.
Replace deprecated gradle configurations compile, testCompile, runtime and testRuntime.
Exclude guava's transitive dependencies jsr305 and animal-sniffer-annotations, and always manually add them as runtimeOnly dependency. error_prone_annotations is an exception: It is also excluded but manually added not as runtimeOnly. It must always compile with guava, otherwise users will see warning spams if guava is in the compile classpath but error_prone_annotations is not (See Many warning messages related to errorprone "CompatibleWith" google/guava#2721).

build.gradle

dapengzhang0 · 2020-04-08T18:12:25Z

@ejona86 Now is ready for review. PTAL.

alts/build.gradle

…onfigurations

ejona86

I got to interop-testing before sort of giving up. The unnecessary changes make this at least 10x harder to review. It is probably best to reduce the diff to only the necessary changes before resuming review.

What I got through I feel fairly confident about. So I could believe one review is enough. But there is just so much noise. It seems like this would have been a fairly easy PR to review without the sorting and rearrangements.

alts/build.gradle

ejona86 · 2020-04-29T19:27:00Z

gae-interop-testing/gae-jdk8/build.gradle

    }
-    compile libraries.netty_tcnative


This looks like it was removed. It seems it should be a runtimeOnly dep.

Does gae-interop-testing really need this?

Yeah, we use tcnative on GAE Java 8 and want to make sure it works, since most people will be using grpc-netty-shaded which includes it. Since v1.25.0 the test probably passes without tcnative, though, since GAE Java 8 includes Conscrypt. But we still want to test with tcnative.

I see. Add it add as runtimeOnly dep in #7001 now.

ejona86 · 2020-04-29T19:31:31Z

grpclb/build.gradle

@@ -11,17 +11,17 @@ description = "gRPC: GRPCLB LoadBalancer plugin"
 evaluationDependsOn(project(':grpc-core').path)

 dependencies {
-    compile project(':grpc-core'),
+    compileOnly libraries.javax_annotation
+    implementation project(':grpc-core'),
            project(':grpc-protobuf'),
            project(':grpc-stub'),


I'm surprised this trailing comma doesn't cause parsing problems. (Travis isn't failing, so it seems it really isn't a problem, but it makes me wonder.)

The line below was accidentally removed by mistake. I think it doesn't cause parsing problems because the next line's return value is appended to the current list.

ejona86 · 2020-04-29T19:33:01Z

grpclb/build.gradle

-        // prefer our own versions instead of protobuf-util's dependency
-        exclude group: 'com.google.guava', module: 'guava'
+    implementation (libraries.protobuf_util) {
+        // prefer our own version from grpc-stub instead of protobuf-util's dependency
        exclude group: 'com.google.errorprone', module: 'error_prone_annotations'


We need to add explicitly dependencies on errorprone and guava to match these excluded ones.

Done in #7001

build.gradle

voidzcy · 2020-04-29T20:02:50Z

grpclb/build.gradle

            project(':grpc-protobuf'),
            project(':grpc-stub'),
-            libraries.protobuf


Why removed direct dependency of protobuf? (Although seems not to break). But since it is an implementation dependency, it might be fine to just rely on the transitive.

I think it was accidentally removed by mistake. Corrected it in #7001.

dapengzhang0

Rebased and fixed the comments in #7001.

dapengzhang0 · 2020-05-04T16:51:11Z

grpclb/build.gradle

            project(':grpc-protobuf'),
            project(':grpc-stub'),
-            libraries.protobuf


I think it was accidentally removed by mistake. Corrected it in #7001.

dapengzhang0 · 2020-05-04T16:53:01Z

grpclb/build.gradle

@@ -11,17 +11,17 @@ description = "gRPC: GRPCLB LoadBalancer plugin"
 evaluationDependsOn(project(':grpc-core').path)

 dependencies {
-    compile project(':grpc-core'),
+    compileOnly libraries.javax_annotation
+    implementation project(':grpc-core'),
            project(':grpc-protobuf'),
            project(':grpc-stub'),


The line below was accidentally removed by mistake. I think it doesn't cause parsing problems because the next line's return value is appended to the current list.

dapengzhang0 · 2020-05-04T16:56:08Z

grpclb/build.gradle

-        // prefer our own versions instead of protobuf-util's dependency
-        exclude group: 'com.google.guava', module: 'guava'
+    implementation (libraries.protobuf_util) {
+        // prefer our own version from grpc-stub instead of protobuf-util's dependency
        exclude group: 'com.google.errorprone', module: 'error_prone_annotations'


Done in #7001

dapengzhang0 · 2020-05-04T16:57:54Z

gae-interop-testing/gae-jdk8/build.gradle

    }
-    compile libraries.netty_tcnative


Does gae-interop-testing really need this?

dapengzhang0 · 2020-05-04T20:54:16Z

Closing in favor of #7001.

dapengzhang0 force-pushed the java-library branch 10 times, most recently from 2ae4da0 to 3dcd610 Compare April 6, 2020 20:20

dapengzhang0 commented Apr 6, 2020

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

dapengzhang0 requested a review from ejona86 April 6, 2020 20:36

dapengzhang0 assigned ejona86 Apr 6, 2020

dapengzhang0 marked this pull request as ready for review April 6, 2020 20:38

dapengzhang0 force-pushed the java-library branch from 3dcd610 to d94a910 Compare April 8, 2020 16:22

ejona86 reviewed Apr 28, 2020

View reviewed changes

alts/build.gradle Outdated Show resolved Hide resolved

dapengzhang0 added 8 commits April 27, 2020 20:16

context: migrate away deprecated gradle configurations

432f47a

all: use java-library gradle plugin for grpc-api

b05a22c

core,netty,okhttp: use java-library plugin for grpc-core

9bd2f7c

stub: use java-library gradle plugin

5090e29

compiler: migrate away deprecated gradle configurations

648ce63

protobuf, protobuf-lite: use java-library gradle plugin

b8366a8

auth: use java-library gradle plugin

825679e

benchmarks: migrate away deprecated gradle configurations

d88a309

dapengzhang0 force-pushed the java-library branch from 80b89ac to 9630645 Compare April 28, 2020 03:26

dapengzhang0 added 4 commits April 27, 2020 23:44

all: use java-library gradle plugin for grpc-census

c25e376

grpclb: migrate away deprecated gradle configurations

dfa15e7

netty: use java-library gradle plugin

ad39f55

okhttp: use java-library gradle plugin

901f95d

dapengzhang0 added 9 commits April 27, 2020 23:44

rls: migrate away deprecated gradle configurations

553bde2

services: use java-library gradle plugin

af87b65

xds: migrate away deprecated gradle configurations

318e601

alts: use java-library gradle plugin

3e1d1e4

testing,testing-proto: use java-library gradle plugin

60ecf5f

android,cronet: use api configuration with android library gradle plugin

2f36dbb

interop-testing,gae-interop-testing: migrate away deprecated gradle c…

ef780f3

…onfigurations

build: fix resolutionStrategy

0762b98

grpc-all: migrate away deprecated gradle configurations

6b4b151

dapengzhang0 force-pushed the java-library branch from 9630645 to 6b4b151 Compare April 28, 2020 06:56

dapengzhang0 requested a review from voidzcy April 28, 2020 21:03

ejona86 reviewed Apr 29, 2020

View reviewed changes

voidzcy reviewed Apr 29, 2020

View reviewed changes

dapengzhang0 commented May 4, 2020

View reviewed changes

dapengzhang0 closed this May 4, 2020

dapengzhang0 deleted the java-library branch May 4, 2020 23:44

github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: migrate gradle build to java-library plugin #6902

all: migrate gradle build to java-library plugin #6902

dapengzhang0 commented Apr 5, 2020 •

edited

Loading

dapengzhang0 commented Apr 8, 2020

ejona86 left a comment

ejona86 Apr 29, 2020

dapengzhang0 May 4, 2020 •

edited

Loading

ejona86 May 4, 2020

dapengzhang0 May 4, 2020

ejona86 Apr 29, 2020

dapengzhang0 May 4, 2020

ejona86 Apr 29, 2020

dapengzhang0 May 4, 2020 •

edited

Loading

voidzcy Apr 29, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 left a comment

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 May 4, 2020

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 commented May 4, 2020

all: migrate gradle build to java-library plugin #6902

all: migrate gradle build to java-library plugin #6902

Conversation

dapengzhang0 commented Apr 5, 2020 • edited Loading

dapengzhang0 commented Apr 8, 2020

ejona86 left a comment

Choose a reason for hiding this comment

ejona86 Apr 29, 2020

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020 • edited Loading

Choose a reason for hiding this comment

ejona86 May 4, 2020

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020

Choose a reason for hiding this comment

ejona86 Apr 29, 2020

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020

Choose a reason for hiding this comment

ejona86 Apr 29, 2020

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020 • edited Loading

Choose a reason for hiding this comment

voidzcy Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020 • edited Loading

Choose a reason for hiding this comment

dapengzhang0 left a comment

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020 • edited Loading

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020 • edited Loading

Choose a reason for hiding this comment

dapengzhang0 May 4, 2020 • edited Loading

Choose a reason for hiding this comment

dapengzhang0 commented May 4, 2020

dapengzhang0 commented Apr 5, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

voidzcy Apr 29, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading

dapengzhang0 May 4, 2020 •

edited

Loading