all: migrate gradle build to java-library plugin #7001
Conversation
dapengzhang0
force-pushed
the
java-library-all
branch
from
65b87d5
to
115825e
Compare
dapengzhang0
force-pushed
the
java-library-all
branch
from
115825e
to
582b48c
Compare
| @@ -10,19 +10,20 @@ plugins { | |||
| description = 'gRPC: Protobuf' | |||
|
|
|||
| dependencies { | |||
| compile project(':grpc-api'), | |||
| api project(':grpc-api'), | |||
| libraries.jsr305, | |||
| libraries.animalsniffer_annotations | ||
| guavaDependency 'compile' | ||
| api project(':grpc-context'), | ||
| libraries.jsr305 |
There was a problem hiding this comment.
It is part of public API signature.
There was a problem hiding this comment.
I mean annotations like @javax.annotation.concurrent.ThreadSafe, @javax.annotation.Nullable are part of some public API signature.
| } | ||
| compile libraries.netty_tcnative | ||
| implementation libraries.protobuf | ||
| implementation libraries.truth |
There was a problem hiding this comment.
Trying to build without it:
/Users/zdapeng/git/grpc-java/gae-interop-testing/gae-jdk8/src/main/java/io/grpc/testing/integration/NettyClientInteropServlet.java:137: error: cannot find symbol
assertTrue(builder instanceof NettyChannelBuilder);
The reason should be that truth was a dep of grpc-interop-testing which is now changed from compile to implementation. Only api/compile dep is transitive for compileClasspath across subproject. Implementation dep is transitive for runtimeClasspath.
There was a problem hiding this comment.
assertTrue is a junit method. This should probably be implementation libraries.junit.
There was a problem hiding this comment.
You are right. My mistake. Done.
| @@ -31,7 +31,7 @@ for (subproject in rootProject.subprojects) { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile subprojects.minus(project(':grpc-protobuf-lite')) | |||
| implementation subprojects.minus(project(':grpc-protobuf-lite')) | |||
There was a problem hiding this comment.
It seems we should use api here. @ejona86 what do you think?
There was a problem hiding this comment.
It is probably better to use api to avoid breaking people. That said, I don't have too much sympathy for someone using grpc-all these days (vs early-on-pre-1.0 when it was used more heavily).
apifor dependencies that are part of grpc public api signatures.compile,testCompile,runtimeandtestRuntime.compile/implementationdependency for our project. Ideally we should include both X and Y explicitly asimplementationdependency for our project, but in this PR we don't add the missing Y if it is previously missing. A followup PR will try to add all such missing dependencies by setting