-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: migrate gradle build to java-library plugin #7001
Changes from all commits
3b866a0
fba7883
6bf2907
deefce4
1133620
da0ac38
fb26a0a
0a31810
3792677
c0742cb
636bec2
d62f22f
521399e
acbff9e
ef60e3b
a70e0b7
74f0aa9
7d1ae54
1a988d3
582b48c
50fee92
694fe0d
a0c33c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
plugins { | ||
id "java" | ||
id "java-library" | ||
id "maven-publish" | ||
|
||
id "me.champeau.gradle.jmh" | ||
|
@@ -11,13 +11,11 @@ description = 'gRPC: API' | |
evaluationDependsOn(project(':grpc-context').path) | ||
|
||
dependencies { | ||
compile project(':grpc-context'), | ||
libraries.errorprone, | ||
libraries.jsr305, | ||
libraries.animalsniffer_annotations | ||
guavaDependency 'compile' | ||
api project(':grpc-context'), | ||
libraries.jsr305 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why expose this one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is part of public API signature. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean annotations like |
||
guavaDependency 'implementation' | ||
|
||
testCompile project(':grpc-context').sourceSets.test.output, | ||
testImplementation project(':grpc-context').sourceSets.test.output, | ||
project(':grpc-testing'), | ||
project(':grpc-grpclb'), | ||
libraries.guava_testlib | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we should use
api
here. @ejona86 what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably better to use
api
to avoid breaking people. That said, I don't have too much sympathy for someone using grpc-all these days (vs early-on-pre-1.0 when it was used more heavily).