Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: sync Envoy proto to commit fd28e42f31730f5ed6f13f52999692a4885dd312 (2020-09-15) #7445

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Sep 21, 2020

Import RouteAction protos with change introduced by envoyproxy/envoy#13018, which is used for gRPC xDS timeout.

Internal envoy import CL: cl/332279092


Manual changes:

  • Suppress warnings for using listening_addresses in io.envoyproxy.envoy.config.core.v3.Node as it's been deprecated.

@voidzcy
Copy link
Contributor Author

voidzcy commented Sep 21, 2020

The listening_addresses field in Node has been deprecated in envoyproxy/envoy#12691, implementations should migrate away from it.

/cc @sanjaypujare

@dapengzhang0
Copy link
Member

Seems we need @sanjaypujare's change first?

@voidzcy voidzcy force-pushed the dep/import_envoy_proto_09_21_2020 branch from 125d96d to 1d4e616 Compare September 21, 2020 23:25
@voidzcy
Copy link
Contributor Author

voidzcy commented Sep 21, 2020

Seems we need @sanjaypujare's change first?

It may take some time for him to completely get rid of usages for listening_addresses field. So I am suppressing that warning for now. The good news is that only happens for EnvoyProtoData.

@voidzcy voidzcy merged commit a5ae55e into grpc:master Sep 22, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
…312 (2020-09-15) (grpc#7445)

Sync Envoy proto to commit fd28e42f31730f5ed6f13f52999692a4885dd312 (2020-09-15, internal Envoy import CL: cl/332279092). Suppressed warning for using listening_addresses in Node and added TODO for cleaning it up.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants