grpc-js: Shutdown transport if a state change occurs while connecting #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Jan 16, 2024
murgatroid99
merged commit b8dc020
into
grpc:@grpc/[email protected]
4 of 5 checks passed
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this promise resolution handler, we have a transport that has just finished connecting. We only use it if the subchannel is currently in the CONNECTING state. If it is not, we just drop the transport on the floor. However, it is still holding the resources related to an established connection, so we have to release those by calling
transport.shutdown().I discovered this bug while investigating #2641.