chore: bump gRPC versions #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik151192
force-pushed
the
bump-grpc
branch
from
ebd3616
to
5a9d90c
Compare
|
This mostly depends on momentohq/client-protos#265 for build to succeed |
cprice404
reviewed
Feb 13, 2024
| @@ -54,7 +54,7 @@ | |||
| "dependencies": { | |||
| "@gomomento/generated-types": "0.106.0", | |||
There was a problem hiding this comment.
i think you will need to bump this too
pratik151192
force-pushed
the
bump-grpc
branch
from
36d74eb
to
545d38e
Compare
anitarua
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC 1.9.14 release had a couple fixes relevant to issues we were seeing with reconnections:
v1.9.0, channel is stuck inCONNECTINGstate for ~20s when reconnecting grpc/grpc-node#2620