Pulling to make workspace up to date wrt master. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move more tests to Linux hosts * fix test
* (Update and) Integrate Rendering README into code * Add mising whitespace * Review comments and other touch-ups
…10337) Extract layout logic in material app bar to a common file that can be reused for cupertino
…nBar (flutter#10423) Create a CupertinoNavigationBar without automatic adding of the lead button
* preview of prefer_asserts_in_initializer_list lint * fix issue
Picks up accessibility fixes.
* have app loggers log to their parent logger * rename field to parent * add todo * revert flutter_tools.iml change * ping the bots
* add min version checks for IntelliJ * validate the installed versions of IntelliJ and the flutter plugin * review comments
This prevents some of our mixins from being subclassed. Also, move mixins to using 'extends' instead of 'implements' for future compatibility with Dart changes. Also, rename a class that had Mixin in the name but was not a mixin.
* Small setup doc for the app store option * review notes
Adds support for requesting keyboards optimised for email address and URL entry.
… order within the same container (flutter#10425)
Should be reverted when flutter#6577 is fixed.
flutter#10675) * Prefix and Suffix support for TextFields * Adding Tests * Removing spurious newline. * Fixing a small problem with the test * Review Changes
* [accessibility] Announce index if tab in tab bar * added TODO
* Benchmark for semantic overhead during transitions * review comments
* upload master and alpha docs to different hosts * include robots.txt when master
* started copying stuff into cupertino page route * extracted from material page route. Ready for testing * works with button and gesture * tests and docs * review notes * review notes
…r#10725) package:test does not allow main() methods to have required arguments - changing to an optional positional arguments list fixes this.
This code is unused in any test. In upcoming changes that migrate to Xcode instruments based device listing, we'll mock out the instruments output separately.
Pulling from main fork.
gspencergoog
pushed a commit
that referenced
this pull request
Feb 12, 2018
* Revert "Revert "Reduce noise in xcodebuild stdout (flutter#14586)" (flutter#14605)" This reverts commit 8e2278b. * Specify the build config when cleaning
gspencergoog
pushed a commit
that referenced
this pull request
Feb 12, 2018
Merging to get back to a green tree.
gspencergoog
pushed a commit
that referenced
this pull request
Feb 13, 2018
* Revert "Revert "Reduce xcodebuild noise #2" (flutter#14641)" This reverts commit 2d47481. * Stop scrapping xcodebuild output, get the right build settings * clone the command params first
gspencergoog
pushed a commit
that referenced
this pull request
Mar 27, 2018
This caused a test failure in the integration_ui_ios devicelab test. ``` stdout: [ +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m stdout: [ +5 ms] DriverError: Failed to fulfill Tap: Flutter application not responding stdout: [ ] Original error: TimeoutException after 0:00:07.500000: Future not completed stdout: [ ] Original stack trace: stdout: [ ] #0 FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18) stdout: [ ] stdout: [ ] #1 FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11) stdout: [ ] stdout: [ ] #2 main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20) ``` This reverts commit 067be92.
gspencergoog
pushed a commit
that referenced
this pull request
May 8, 2018
This test fails consistently on mac2 and mac3 with the attached Moto G4 devices but passes consistently on other machines. Adding a delay of 1s right after driver.connect() in setUpAll() causes it to pass on the machines in question, which suggests a race condition. Specifically it looks like connect returns the moment Flutter Driver identifies that the isolate is up and running, but empirically it looks like we start running the first test before the UI is actually up. This triggers a failure wherein we start looking for elements before they're onstage. Link to viewport.dart:213 at HEAD: https://github.com/flutter/flutter/blob/b2b46659262c66ff13abc2b8016a94a47646eaad/packages/flutter/lib/src/widgets/viewport.dart#L213 Stack trace: FlutterDriver waitFor should find text "present" ``` DriverError: Error in Flutter application: Uncaught extension error while executing waitFor: NoSuchMethodError: The getter 'visible' was called on null. Receiver: null Tried calling: visible #0 Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:46:5) #1 _ViewportElement.debugVisitOnstageChildren. (package:flutter/src/widgets/viewport.dart:213:36) #2 WhereIterator.moveNext (dart:_internal/iterable.dart:439:11) #3 Iterable.forEach (dart:core/iterable.dart) #4 _ViewportElement.debugVisitOnstageChildren (package:flutter/src/widgets/viewport.dart:214:8) #5 _DepthFirstChildIterator._reverseChildrenOf (package:flutter_test/src/all_elements.dart:54:15) #6 _DepthFirstChildIterator.moveNext (package:flutter_test/src/all_elements.dart:45:19) #7 CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27) #8 _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21) #9 WhereIterator.moveNext (dart:_internal/iterable.dart:438:22) #10 CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27) #11 _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21) #12 Iterable.isEmpty (dart:core/iterable.dart:449:33) #13 Iterable.isNotEmpty (dart:core/iterable.dart:456:27) #14 FlutterDriverExtension._waitForElement. (package:flutter_driver/src/extension/extension.dart:215:51) #15 FlutterDriverExtension._waitUntilFrame (package:flutter_driver/src/extension/extension.dart:197:19) #16 FlutterDriverExtension._waitForElement (package:flutter_driver/src/extension/extension.dart:215:11) #17 FlutterDriverExtension._waitFor (package:flutter_driver/src/extension/extension.dart:286:11) #18 FlutterDriverExtension.call (package:flutter_driver/src/extension/extension.dart:168:51) #19 BindingBase.registerServiceExtension. (package:flutter/src/foundation/binding.dart:370:32) ``` Removes a previous hack that no longer appears to help (adding a 1 second delay in setUpAll() does seem to work around this issue though).
gspencergoog
pushed a commit
that referenced
this pull request
Oct 26, 2018
…wBox (flutter#23492) Bug #1: These didn't work with directional alignments, due to an error in the types of the constructor arguments. Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As soon as I wrote a test for it, the test showed that there was a fundamental bug in its performLayout method: it didn't set parentUsesSize, but it immediately tried to use the child's size.
gspencergoog
pushed a commit
that referenced
this pull request
Sep 4, 2020
…ated (flutter#65184) More work to prevent current #2 crash issue on stable. If adb is not located do not list/create android devices.
gspencergoog
pushed a commit
that referenced
this pull request
Dec 4, 2020
…1498)" (flutter#71519) This appears to be triggering an null dereference by calling popSystemNavigator on a null platform plugin delegate. boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator() Relevant logs: ``` 2020-12-01T14:34:34.410242: stderr: [ +6 ms] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.490211: stderr: [ +79 ms] VMServiceFlutterDriver: <<< {isError: false, response: {text: ok}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.493011: stderr: [ +2 ms] VMServiceFlutterDriver: >>> {command: tap, finderType: ByValueKey, keyValueString: step, keyValueType: String} 2020-12-01T14:34:34.962001: stdout: [ +468 ms] E/MethodChannel#flutter/platform( 9732): Failed to handle method call 2020-12-01T14:34:34.962222: stdout: [ ] E/MethodChannel#flutter/platform( 9732): java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.962356: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) 2020-12-01T14:34:34.962499: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.962735: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.963047: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.963284: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.963592: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.963910: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.964227: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.964571: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.964805: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.965034: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.965248: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.965398: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.965589: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) 2020-12-01T14:34:34.966863: stderr: [ +1 ms] VMServiceFlutterDriver: <<< {isError: false, response: {}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.967698: stderr: [ ] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.986399: stdout: [ +18 ms] E/flutter ( 9732): [ERROR:flutter/shell/common/shell.cc(209)] Dart Unhandled Exception: PlatformException(error, Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference, null, java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.986682: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.987013: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.987328: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.987547: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.987815: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.988037: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.988246: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.988470: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.988678: stdout: [ ] E/flutter ( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.988934: stdout: [ ] E/flutter ( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.989112: stdout: [ ] E/flutter ( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.989348: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.990016: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) stdout: [ ] E/flutter ( 9732): ), stack trace: #0 JSONMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:159:7) stdout: [ ] E/flutter ( 9732): #1 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:159:18) 2020-12-01T14:34:34.990374: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> 2020-12-01T14:34:34.990702: stdout: [ ] E/flutter ( 9732): #2 SystemNavigator.pop (package:flutter/src/services/system_navigator.dart:34:5) 2020-12-01T14:34:34.990946: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> ``` This reverts commit 6a84b02.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.