on_stats request option #1202
on_stats request option #1202
Conversation
|
Looks pretty nice. :) |
|
Do you think the TransferStats class actually needs accessor methods, or should it just use public properties? |
|
Private properties with accessors is the best design wise, but public properties might save time. I use public properties more and more as I find it makes things easy to test and fast to write. |
|
Just out of interest, what still needs to happen here? |
|
@stefanruijsenaars mostly just tests and docs |
|
This feature is now complete. How does it look from a functionality point of view,@GrahamCampbell / @Crell? |
| use GuzzleHttp\TransferStats; | ||
| use GuzzleHttp\Psr7; | ||
|
|
||
| class TransferStatsTest extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
Just curious: you don't use @coversDefaultClass and @Covers right?
|
The general code looks pretty sane for me |
|
It's possibile to extract that information from a middleware? |
|
Can't your middleware manipulate the $options passed into the further down middleware/handler and by that register a callable? |
|
Oh yes, I can do that! Thanks |
This is WIP commit that adds the
on_statsrequest option.Closes #1152