fix: Allow setting Textbox "value" dynamically #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow Textbox "value" to be set from wave app * add tests for TextField and MaskedTextField * fix warning about act() in tests closes #1578
mturoci
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Thanks @aalencar, looking good overall, just a few small comments from me.
Also can you please extract as part of this PR (unrelated refactor).
const pushMock = jest.fn()
wave.push = pushMockto the top of the test file so that we create pushMock just once and not per test case?
mturoci
approved these changes
Sep 5, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-08-24.at.14.22.13.mov
closes #1578