-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow setting Textbox "value" dynamically #1606
Conversation
* allow Textbox "value" to be set from wave app * add tests for TextField and MaskedTextField * fix warning about act() in tests closes #1578
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aalencar, looking good overall, just a few small comments from me.
Also can you please extract as part of this PR (unrelated refactor).
const pushMock = jest.fn()
wave.push = pushMock
to the top of the test file so that we create pushMock just once and not per test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @aalencar!
Screen.Recording.2022-08-24.at.14.22.13.mov
closes #1578