Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow setting Textbox "value" dynamically #1606

Merged
merged 8 commits into from
Sep 5, 2022
Merged

fix: Allow setting Textbox "value" dynamically #1606

merged 8 commits into from
Sep 5, 2022

Commits on Aug 24, 2022

  1. fix: allow setting Textbox "value" dynamically #1578 

    * allow Textbox "value" to be set from wave app
* add tests for TextField and MaskedTextField
* fix warning about act() in tests

closes #1578
    @aalencar
    aalencar committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1421be3 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. docs: Add comment on why we need to reset props for every test

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e32d681 View commit details
    Browse the repository at this point in the history

  2. refactor: Move wave.push setup to the top

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c63ad05 View commit details
    Browse the repository at this point in the history

  3. refactor: Pass wave.push reference directly instead of using a callback

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    96bee41 View commit details
    Browse the repository at this point in the history

  4. tests: remove unnecessary clean up code

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4cc0ec5 View commit details
    Browse the repository at this point in the history

  5. tests: Remove unnecessary 'act' calls

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    21bbf7c View commit details
    Browse the repository at this point in the history

  6. tests: Revert test for 'Calls sync - trigger'

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    cb1e244 View commit details
    Browse the repository at this point in the history

  7. fix: Set wave args properly when "value" prop changes

    @aalencar
    aalencar committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6225bd7 View commit details
    Browse the repository at this point in the history