Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1074 keyboard users loose focus #1161

Closed
wants to merge 5 commits into from
Closed

#1074 keyboard users loose focus #1161

wants to merge 5 commits into from

Conversation

hasham-qaiser
Copy link
Member

this pr addresses a fix for issue #1074

-addressed issues and implemented useEffect statements and useRef statements regarding the pages the affirmation component pops up on.

-added statements to corresponding pages.

-may need to refractor or edit

@hasham-qaiser hasham-qaiser added the role: development anything related to code label Feb 13, 2024
@whitneywind
Copy link
Member

whitneywind commented Feb 14, 2024

@hasham-qaiser This works so well! For the last one do you think we should set the focus to go to through the edit icons or jump down to the bottom?

@hasham-qaiser
Copy link
Member Author

@hasham-qaiser This works so well! For the last one do you think we should set the focus to go to through the edit icons or jump down to the bottom?

trying to find out what works best for a keyboard user experience, I'm assuming going through the edit icons would be better

@hasham-qaiser hasham-qaiser added the ready for dev lead task ready for dev lead to evaluate label Feb 14, 2024
@hasham-qaiser hasham-qaiser deleted the user-focus branch February 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead task ready for dev lead to evaluate role: development anything related to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants