Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1074 keyboard users loose focus #1161

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions products/statement-generator/src/components/Checkbox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,29 +44,29 @@ interface IInnerCheckboxProps extends CheckboxProps {
useTeal?: boolean;
}

const InnerCheckbox = ({
checked,
onChange,
id,
useTeal,
}: IInnerCheckboxProps) => {
const classes = useStyles({ theme: useTeal ? 'teal' : 'black' });
return (
<Checkbox classes={classes} checked={checked} onChange={onChange} id={id} />
);
};
const InnerCheckbox = React.forwardRef<HTMLInputElement, IInnerCheckboxProps>(
({ checked, onChange, id, useTeal }, ref) => {
const classes = useStyles({ theme: useTeal ? 'teal' : 'black' });
return (
<Checkbox
classes={classes}
checked={checked}
onChange={onChange}
id={id}
inputRef={ref}
/>
);
}
);

interface IWrapperCheckboxProps extends IInnerCheckboxProps {
label: string;
}

const CheckboxLabels: React.FC<IWrapperCheckboxProps> = ({
label,
checked,
onChange,
id,
useTeal = false,
}) => {
const CheckboxLabels = React.forwardRef<
HTMLInputElement,
IWrapperCheckboxProps
>(({ label, checked, onChange, id, useTeal = false }, ref) => {
return (
<FormControlLabel
control={
Expand All @@ -75,11 +75,12 @@ const CheckboxLabels: React.FC<IWrapperCheckboxProps> = ({
id={id}
checked={checked}
onChange={onChange}
ref={ref}
/>
}
label={label}
/>
);
};
});

export default CheckboxLabels;
86 changes: 48 additions & 38 deletions products/statement-generator/src/components/TextPreview.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { forwardRef, useState } from 'react';

import { makeStyles, createStyles } from '@material-ui/core';
import CreateIcon from '@material-ui/icons/Create';
Expand Down Expand Up @@ -43,47 +43,57 @@ interface ComponentProps {
style?: object;
}

const TextPreview = ({
onSaveClick,
content,
nameOfStep,
className = '',
style,
}: ComponentProps) => {
const classes = useStyles();
const utilityClasses = useUtilityStyles();
const [isEditing, setIsEditing] = useState<boolean>(false);
const TextPreview = forwardRef<HTMLDivElement, ComponentProps>(
({ onSaveClick, content, nameOfStep, className = '', style }, ref) => {
const classes = useStyles();
const utilityClasses = useUtilityStyles();
const [isEditing, setIsEditing] = useState<boolean>(false);

const handleClick = () => {
setIsEditing(true);
};
const handleClick = () => {
setIsEditing(true);
};

return (
<div className={`${classes.root} ${className}`} style={style}>
<div className={classes.previewHeader}>
<h3>{nameOfStep}</h3>
return (
<div
ref={ref}
className={`${classes.root} ${className}`}
style={style}
tabIndex={-1}
>
<div className={classes.previewHeader}>
<h3>{nameOfStep}</h3>

<div className={classes.actionHeader}>
{!isEditing && (
<CreateIcon
className={utilityClasses.iconButton}
onClick={handleClick}
/>
)}
<div className={classes.actionHeader}>
{!isEditing && (
<CreateIcon
className={`${utilityClasses.iconButton} create-icon-focusable`}
onClick={handleClick}
tabIndex={0}
role="button"
aria-label="Edit content"
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
handleClick();
e.preventDefault();
}
}}
/>
)}
</div>
</div>
</div>

{isEditing ? (
<EditContent
content={content}
setIsEditing={setIsEditing}
onSaveClick={onSaveClick}
/>
) : (
<p>{content}</p>
)}
</div>
);
};
{isEditing ? (
<EditContent
content={content}
setIsEditing={setIsEditing}
onSaveClick={onSaveClick}
/>
) : (
<p>{content}</p>
)}
</div>
);
}
);

export default TextPreview;
82 changes: 44 additions & 38 deletions products/statement-generator/src/components/Textarea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,45 +78,51 @@ interface TextFieldProps {
rows?: number;
}

const MultilineTextFields: React.FC<TextFieldProps> = ({
handleChange,
id,
label,
placeholder,
defaultValue,
disabled = false,
value,
rows,
}) => {
const utilityClasses = useUtilityStyles();
const classes = useStyles();
const MultilineTextFields = React.forwardRef<HTMLDivElement, TextFieldProps>(
(
{
handleChange,
id,
label,
placeholder,
defaultValue,
disabled = false,
value,
rows,
},
ref
) => {
const utilityClasses = useUtilityStyles();
const classes = useStyles();

return (
<div className={utilityClasses.formInput}>
{label && (
<InputLabel htmlFor={id} disabled={disabled}>
{label}
</InputLabel>
)}
return (
<div className={utilityClasses.formInput}>
{label && (
<InputLabel htmlFor={id} disabled={disabled}>
{label}
</InputLabel>
)}

<TextField
id={id}
className={classes.textfieldComponent}
onChange={handleChange}
placeholder={placeholder}
defaultValue={defaultValue}
disabled={disabled}
value={value}
rows={rows}
multiline
fullWidth
variant="outlined"
InputProps={{
notched: false,
}}
/>
</div>
);
};
<TextField
id={id}
className={classes.textfieldComponent}
onChange={handleChange}
placeholder={placeholder}
defaultValue={defaultValue}
disabled={disabled}
value={value}
rows={rows}
multiline
fullWidth
variant="outlined"
InputProps={{
notched: false,
}}
inputRef={ref}
/>
</div>
);
}
);

export default MultilineTextFields;
22 changes: 20 additions & 2 deletions products/statement-generator/src/pages-form/FinalizeForm.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useContext } from 'react';
import React, { useContext, useEffect, useRef } from 'react';
import { useTranslation } from 'react-i18next';
import { makeStyles, createStyles } from '@material-ui/core';
import VisibilityIcon from '@material-ui/icons/Visibility';
Expand All @@ -20,6 +20,8 @@ import {
PREVIEW_KEYS,
} from 'helpers/previewHelper';

import { AffirmationContext } from 'contexts/AffirmationContext';

const useStyles = makeStyles(({ palette, spacing }) =>
createStyles({
previewItem: {
Expand All @@ -46,6 +48,22 @@ function FinalizeForm() {
const classes = useStyles();
const { formState, updateStepToForm } = useContext(FormStateContext);

const { affirmationData } = useContext(AffirmationContext);

const previewsContainerRef = useRef<HTMLDivElement>(null);

useEffect(() => {
if (!affirmationData.isActive) {
const firstFocusableElement = previewsContainerRef.current?.querySelector(
'button, [href], input, select, textarea, [tabindex]:not([tabindex="0"])'
);

if (firstFocusableElement instanceof HTMLElement) {
firstFocusableElement.focus();
}
}
}, [affirmationData.isActive]);

function updatePreviewItem(newStatement: string, stateKey: string) {
updateStepToForm({
statements: {
Expand Down Expand Up @@ -88,7 +106,7 @@ function FinalizeForm() {
Editing final letter
</div>

{previewComponents}
<div ref={previewsContainerRef}>{previewComponents}</div>

<TextPreview
className={classes.previewItem}
Expand Down
15 changes: 14 additions & 1 deletion products/statement-generator/src/pages-form/GoalsStep.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useContext } from 'react';
import React, { useContext, useEffect, useRef } from 'react';
import { useTranslation } from 'react-i18next';

import FormStateContext from 'contexts/FormStateContext';
Expand All @@ -8,11 +8,23 @@ import FlowNavigation from 'components-layout/FlowNavigation';
import ContentContainer from 'components-layout/ContentContainer';
import Textarea from 'components/Textarea';

import { AffirmationContext } from 'contexts/AffirmationContext';

function GoalsStep() {
const { t } = useTranslation();
const { formState, updateStepToForm } = useContext(FormStateContext);
const { goals, goalsHow } = formState.goalsState;

const { affirmationData } = useContext(AffirmationContext);

const goalsRef = useRef<HTMLInputElement>(null);

useEffect(() => {
if (!affirmationData.isActive) {
goalsRef.current?.focus();
}
}, [affirmationData.isActive]);

const goalsValid = goals !== '';
const goalsHowValid = goalsHow !== '';
const isNextDisabled = !goalsValid || !goalsHowValid;
Expand All @@ -28,6 +40,7 @@ function GoalsStep() {
return (
<ContentContainer>
<Textarea
ref={goalsRef}
id="goals"
label={t('goals_form.goals_input_label')}
placeholder={t('goals_form.goals_input_placeholder')}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useContext } from 'react';
import React, { useContext, useEffect, useRef } from 'react';
import { Theme, createStyles, makeStyles } from '@material-ui/core/styles';
import FormLabel from '@material-ui/core/FormLabel';
import FormControl from '@material-ui/core/FormControl';
Expand All @@ -7,6 +7,8 @@ import { useTranslation } from 'react-i18next';

import FormStateContext from 'contexts/FormStateContext';

import { AffirmationContext } from 'contexts/AffirmationContext';

import Checkbox from 'components/Checkbox';

import ContentContainer from 'components-layout/ContentContainer';
Expand All @@ -33,6 +35,14 @@ const useStyles = makeStyles<Theme>(({ palette, spacing }) =>
function InvolvementInitialFlow() {
const { t } = useTranslation();
const classes = useStyles();
const { affirmationData } = useContext(AffirmationContext);
const firstCheckboxRef = useRef<HTMLInputElement>(null);

useEffect(() => {
if (!affirmationData.isActive) {
firstCheckboxRef.current?.focus();
}
}, [affirmationData.isActive]);

const { formState, updateStepToForm } = useContext(FormStateContext);
const {
Expand Down Expand Up @@ -73,6 +83,7 @@ function InvolvementInitialFlow() {
</FormLabel>
<FormGroup id="involvement-checkboxes">
<Checkbox
ref={firstCheckboxRef}
useTeal
id="isJobChecked"
checked={isJobChecked}
Expand Down
Loading