Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The option "--no-escape" does not work #219

Open
filipbartek opened this issue Feb 6, 2019 · 0 comments
Open

The option "--no-escape" does not work #219

filipbartek opened this issue Feb 6, 2019 · 0 comments

Comments

@filipbartek
Copy link

filipbartek commented Feb 6, 2019 •
edited
Loading

The option --no-escape does not ampersand ("&") characters from being escaped in HTML output in field "employment.history[0].position".

This has been also observed by @vidyu:

@hacksalot the --no-escape option doesn't work though.

Originally posted by @vidyu in #199 (comment)

I am planning to attempt to fix this issue.
filipbartek added a commit to filipbartek/HackMyResume that referenced this issue Feb 6, 2019
@filipbartek
Fix propagation of --no-escape to handlebars
567b5af 
Fixes hacksalot#219
filipbartek added a commit to filipbartek/HackMyResume that referenced this issue Feb 6, 2019
@filipbartek
Use escape instead of noescape in _opts
18ab372 
Make the escaping option similar to `prettify` in `_opts` by making it
positive. The `_opts` option `prettify` is exposed in CLI as
--no-prettify, similarly to `escape` exposed as --no-escape.

Refactor.

Corollary of hacksalot#219
@filipbartek filipbartek mentioned this issue Feb 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filipbartek