Fix the option --no-escape #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the escaping option similar to `prettify` in `_opts` by making it positive. The `_opts` option `prettify` is exposed in CLI as --no-prettify, similarly to `escape` exposed as --no-escape. Refactor. Corollary of hacksalot#219
|
I think the test failures are caused by #221. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
I verified the correctness by running the tests with
grunt test. The output shows the same 11 test failures as when run ondev. Moreover, I tested the fixed functionality manually by generating a HTML resume with an ampersand (&) character in a job title.