Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改默认的评论组件资源地址,目前使用的 jsDelivr 在部分地区已经无法正常访问 #2097

Closed
ruibaby opened this issue May 19, 2022 · 6 comments · Fixed by #2098
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to a improvement.
Milestone

Comments

@ruibaby
Copy link
Member

ruibaby commented May 19, 2022

你当前使用的版本

1.5.3

描述一下此特性

#1619 中遗漏了默认的评论组件资源地址。

目前需要修改的位置:

/kind improvement
/cc @halo-dev/sig-halo

在 2.0 实现评论插件之前,可以暂时使用 unpkg 代替。

https://unpkg.com/[email protected]/dist/halo-comment.min.js

附加信息

No response

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2022

@ruibaby: The label(s) kind/improvement cannot be applied, because the repository doesn't have them.

In response to this:

你当前使用的版本

1.5.3

描述一下此特性

#1619 中遗漏了默认的评论组件资源地址。

目前需要修改的位置:

/kind improvement
/cc @halo-dev/sig-halo

在 2.0 实现评论插件之前,可以暂时使用 unpkg 代替。

https://unpkg.com/[email protected]/dist/halo-comment.min.js

附加信息

No response

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby
Copy link
Member Author

ruibaby commented May 19, 2022

/milestone 1.5.x

@f2c-ci-robot f2c-ci-robot bot added this to the 1.5.x milestone May 19, 2022
@Yhcrown
Copy link

Yhcrown commented May 19, 2022

/assign

@ruibaby
Copy link
Member Author

ruibaby commented May 19, 2022

/kind improvement

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label May 19, 2022
@JohnNiang
Copy link
Member

/good-first-issue

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2022

@JohnNiang:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants